WaylandBackend: Fix hotkeys failing to bind on Wayland desktops #1666
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per Wayland protocol specsheet regarding keymapping: "From version 7 onwards, the fd must be mapped with MAP_PRIVATE by the recipient, as MAP_SHARED may fail." This matches up exactly with what we're seeing with this error: [gamescope] [Error] xdg_backend: Failed to map keymap fd. Changing MAP_SHARED to MAP_PRIVATE per the spec addresses this error. Fixes: ValveSoftware#1658 (hopefully) fixes: ValveSoftware#1637
|
Seems to work. |
|
Works as expected, resolving the Super + hotkey issue #1658. Can't confirm the Super-less hotkey. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Wayland protocol specsheet regarding keymapping: "From version 7 onwards, the fd must be mapped with MAP_PRIVATE by the recipient, as MAP_SHARED may fail."
https://wayland.app/protocols/wayland#wl_keyboard:event:keymap
This matches up exactly with what we're seeing with this error:
[gamescope] [Error] xdg_backend: Failed to map keymap fd.Changing MAP_SHARED to MAP_PRIVATE per the spec addresses this error.
Fixes: #1658
(hopefully) fixes: #1637