Fix crash when handling ValueTuples #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes: - Initial support for field serialization - Initial support for struct serialization This does not flatten the Rest/TRest property of large ValueTuples.
|
There's no test that actually checks for Item1... etc |
|
No, because I wasn't sure yet what we wanted the final output to look like. At the moment this just proves that it doesn't crash. |
xPaw
approved these changes
Nov 7, 2023
|
As discussed on Discord:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes:
Fixes #79.
This does not flatten the Rest/TRest property of large ValueTuples. I'm not sure yet if we should do that, or if we should purely represent the runtime layout of the object.
This also uses the "Item1"/"Item2"/... naming, not the modern C# aliases for the fields (e.g.
(hello: "world")