Standardize separator UI

PokemonRandomizer/PokemonRandomizer/UI/PokemonSettingsUI.cs

@@ -24,7 +24,7 @@ public PokemonSettingsUI(PokemonSettings settings, IEnumerable<string> metricTyp
             if(settings.Data.Count > 0)
             {
                 stack.Add(new MetricDataUI(settings.Data, metricTypeOptions, initialize));
-                stack.Add(new Separator());
+                stack.Separator();
             }
             stack.Add(new BoundCheckBoxUI(settings.BanLegendaries, b => settings.BanLegendaries = b, "Ban Legendaries"));
             stack.Add(new BoundCheckBoxUI(settings.RestrictIllegalEvolutions, b => settings.RestrictIllegalEvolutions = b, "Ban Illegal Evolutions"));

PokemonRandomizer/PokemonRandomizer/UI/UIExtensions.cs

@@ -6,6 +6,8 @@ namespace PokemonRandomizer.UI
 {
     public static class UIExtensions
     {
+        private static Separator StdSeparator => new Separator() { Height = 1, UseLayoutRounding=true };
+
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static T Add<T>(this Panel p, T element) where T : UIElement
         {
@@ -21,11 +23,11 @@ public static void Add(this Panel p, params UIElement[] elements)
         }
         public static void Header(this Panel p, string content)
         {
-            p.Add(new Label { Content = content }, new Separator());
+            p.Add(new Label { Content = content }, StdSeparator);
         }
         public static void Header(this Panel p, string content, string tooltip)
         {
-            p.Add(new Label { Content = content, ToolTip = tooltip }, new Separator());
+            p.Add(new Label { Content = content, ToolTip = tooltip }, StdSeparator);
         }
 
         public static void Description(this Panel p, params string[] content)
@@ -34,7 +36,12 @@ public static void Description(this Panel p, params string[] content)
             {
                 p.Add(new Label() { Content = line });
             }
-            p.Add(new Separator());
+            p.Add(StdSeparator);
+        }
+
+        public static void Separator(this Panel p)
+        {
+            p.Add(StdSeparator);
         }
 
         [MethodImpl(MethodImplOptions.AggressiveInlining)]

PokemonRandomizer/PokemonRandomizer/UI/Views/PokemonTraitsDataView.cs

@@ -117,7 +117,7 @@ private TabItem CreateLearnsetsTab(PokemonTraitsModel model)
             bonusMovesStack.Add(new BoundCheckBoxUI("Ban adding HM moves", model.DisableAddingHmMoves));
             stack.Add(new RandomChanceUI("Bonus Moves", model.AddMoves, model.AddMovesChance, bonusMovesStack));
             stack.Add(bonusMovesStack);
-            stack.Add(new Separator());
+            stack.Separator();
             stack.Header(UISkin.Current.HacksAndTweaksHeader);
             stack.Add(new BoundCheckBoxUI("Ban Selfdestruct", model.BanSelfdestruct, banSelfdestructTooltip));
             return CreateTabItem("Learnsets", stack); ;

PokemonRandomizer/PokemonRandomizer/UI/Views/TmHmTutorDataView.cs

@@ -34,7 +34,7 @@ public TmHmTutorDataView(TmHmTutorModel model)
             stack.Add(new BoundCheckBoxUI("Prevent HM moves in TMs and Tutors", model.NoHmMovesInTMsAndTutors));
             stack.Add(new BoundCheckBoxUI("Prevent duplicate moves in TMs and Tutors", model.NoDuplicateTMsAndTutors));
             stack.Add(new BoundCheckBoxUI("Keep important TMs and Tutors", model.KeepImportantTmsAndTutors, "Ensures that important TMs and Tutors won't be randomized (Secret Power + Dig in RSE)"));
-            stack.Add(new Separator());
+            stack.Separator();
             stack.Header("Compatibility");
             var compatDropdown = stack.Add(new EnumComboBoxUI<CompatOption>("Compatibility Strategy", CompatOptionDropdown, model.MoveCompatOption));
             stack.Add(compatDropdown.BindVisibility(new BoundSliderUI("Random Compatibility Chance", model.RandomCompatTrueChance), (int)CompatOption.Random, (int)CompatOption.RandomKeepNumber));

PokemonRandomizer/PokemonRandomizer/UI/Views/WeatherDataView.cs

@@ -25,7 +25,7 @@ public WeatherDataView(WeatherDataModel model)
         {
             var stack = CreateMainStack();
             stack.Add(new Label() { Content = "Weather Randomization" });
-            stack.Add(new Separator());
+            stack.Separator();
             var strategyDrop = stack.Add(new EnumComboBoxUI<WeatherOption>("Randomization Strategy", WeatherOptionDropdown, model.WeatherSetting));
             strategyDrop.BindVisibility(stack.Add(new WeightedSetUI<Weather>("Custom Weather Type", model.CustomWeatherWeights, GetWeatherWeightDropdown)), (int)WeatherOption.CustomWeighting);
             var settingsStack = stack.Add(strategyDrop.BindEnabled(CreateStack(), (int)WeatherOption.CompletelyRandom, (int)WeatherOption.InBattleWeather, (int)WeatherOption.CustomWeighting));

PokemonRandomizer/PokemonRandomizer/UI/Views/WildEncounterDataView.cs

@@ -25,8 +25,7 @@ public WildEncounterDataView(WildEncounterDataModel model)
         {
             var stack = new StackPanel() { Orientation = Orientation.Vertical };
             Content = stack;
-            stack.Add(new Label() { Content = "Wild Encounter Randomization" });
-            stack.Add(new Separator());
+            stack.Header("Wild Encounter Randomization");
             stack.Add(new EnumComboBoxUI<Strategy>("Randomization Strategy", StrategyDropdown, model.Strategy));
             stack.Add(new PokemonSettingsUI(model.PokemonSettings, MetricTypes, model.InitializeMetric));
         }

PokemonRandomizer/PokemonRandomizer/UI/WeightedSetUI.cs

@@ -52,7 +52,7 @@ public WeightedSetUI(string name, WeightedSet<T> set, Func<IReadOnlyList<MenuBox
             }
             addButton.ContextMenu = contextMenu;
             mainStack.Add(controlStack);
-            mainStack.Add(new Separator());
+            mainStack.Separator();
             foreach(var item in set)
             {
                 Add(item.Key, item.Value);