Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

リポジトリをセットアップ #2

Merged
merged 4 commits into from
Apr 22, 2023

Conversation

sevenc-nanashi
Copy link
Member

内容

軽い説明とスクリプトを追加します。

関連 Issue

スクリーンショット・動画など

(なし)

その他

(なし)

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

READMEありがとうございます!!

これだとちょっとどこがVOICEVOXエディタの方でどこがMOBILEの方かわからないかもですね。
一番上に# VOICEVOX MOBILEを作って、その下に必要なことだけ書いた後、

---
以下は元のエディタのREADMEです

みたいな感じで区切るのどうでしょう。

コンフリクトも起こりにくいし、罠も減らせるので誰か参戦しやすくなるかなと!!

@sevenc-nanashi
Copy link
Member Author

その形にしてみました。

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Hiroshiba Hiroshiba merged commit 34a2f1a into VOICEVOX:main Apr 22, 2023
Hiroshiba added a commit that referenced this pull request Feb 28, 2024
* Fix: エンジンが起動していないと画面が真っ白になるのを修正

* Fix: 型周りを修正

Co-Authored-By: y-chan <[email protected]>

* Fix: talk周りのハンドリングを修正

Co-Authored-By: y-chan <[email protected]>

* Add: テストを追加

* Fix: speakerUuidのインクリメントを修正

* `filterCharacterInfosByStyleType`をstoreでも使うようにする (#2)

* Add: コメントを追加

Co-authored-by: Hiroshiba <[email protected]>

* Refactor: filterCharacterInfosByStyleTypeのテストを整理

* Code: コードのスタイルを修正

* テストコード削減

* ドキュメント調整

---------

Co-authored-by: y-chan <[email protected]>
Co-authored-by: Yuto Ashida <[email protected]>
Co-authored-by: Hiroshiba <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants