Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

現時点での変更をpush #1

Merged
merged 31 commits into from
Apr 22, 2023
Merged

現時点での変更をpush #1

merged 31 commits into from
Apr 22, 2023

Conversation

sevenc-nanashi
Copy link
Member

内容

とりあえずビルド＆コア読み込みできるスマホ版を作りました。

  • Capacitorを導入
  • コアを読み込み＋バージョンを起動時に表示する

関連 Issue

スクリーンショット・動画など

image

その他

iOSはMacを持っている人に任せようと思っています。
このブランチはadd/electron-mockベースになっています。

@sevenc-nanashi
Add: window.electronのモックを追加
8a60185
@sevenc-nanashi
Improve: ブラウザ用にチューニング
5b12da3
@sevenc-nanashi
Revert: 不要な変更をRevert
b99a7d0
@sevenc-nanashi
Fix: 初期化周りを修正
e358a22
@sevenc-nanashi
Revert: チューニング関連をRevert
0af31d3
@sevenc-nanashi
Change: idb-keyvalから離脱
f148c71
@sevenc-nanashi
Update: package-lock.jsonを更新
3094352
@sevenc-nanashi
Change: Promise.resolveからasync functionに
af8b94c
@sevenc-nanashi
Code: no-unused-varsを無効化
fe2be3d
@sevenc-nanashi
Delete: theme-colorを削除
4fb28dd
@sevenc-nanashi
Merge: main -> add/electron-mock
6df38ed
@sevenc-nanashi
Add: Capacitor for Androidをセットアップ
80545ed
@sevenc-nanashi
Fix: ESLintの警告を無視
92036f8
@sevenc-nanashi
Merge: add/electron-mock -> capacitor
09b4b90
@sevenc-nanashi
Add: gradle周りを追加
8292fd8
@sevenc-nanashi
Fix: /homeを/に移動
e8171c1
@sevenc-nanashi
Add: コアを読み込めるように
88e2a9c
@sevenc-nanashi
Fix: プラグイン名を修正
32de59c
@sevenc-nanashi
Fix: ロードできなかったのを修正
6522658
@sevenc-nanashi
Code: build.gradleの細かいところを修正
55f2cb6
@sevenc-nanashi sevenc-nanashi mentioned this pull request Apr 22, 2023
Closed
Hiroshiba
Hiroshiba reviewed Apr 22, 2023
View reviewed changes
android/app/src/main/res/drawable-v24/ic_launcher_foreground.xml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

謎xml

Hiroshiba
Hiroshiba reviewed Apr 22, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いろいろ書いたのですが、まあプロトタイプなのでそのままでも良いかもと思いました！
消去とか面倒であればコメントいただければ

Hiroshiba
Hiroshiba approved these changes Apr 22, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！！

@Hiroshiba Hiroshiba merged commit 13d18a6 into VOICEVOX:main Apr 22, 2023
@sevenc-nanashi sevenc-nanashi mentioned this pull request Apr 24, 2023
Open
@sevenc-nanashi sevenc-nanashi mentioned this pull request Jun 8, 2023
Open
23 tasks
sevenc-nanashi added a commit that referenced this pull request Jan 19, 2024
@sevenc-nanashi @Hiroshiba
Refactor: 修飾キーのcomposableを追加 (VOICEVOX#1711)
e100dc9 
* Refactor: 修飾キーのcomposableを追加

* Dlete: 不要なexportを削除

Co-authored-by: Hiroshiba <[email protected]>

* #1711のテスト書いてみた (#1)

---------

Co-authored-by: Hiroshiba <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sevenc-nanashi @Hiroshiba