FIX: 未処理の例外が発生した場合スタックトレースが表示されない問題を修正 #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takana-v
approved these changes
Nov 20, 2024
takana-v
approved these changes
Nov 20, 2024
Hiroshiba
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
未処理の例外が発生した場合
global_execution_handler内で例外をそのまま捨てていました。結果、例外はコンソールに一切表示されていませんでした。
この問題を修正します。
#1478 (comment)
関連 Issue
その他
例外の内容をレスポンスに含めるのは意図しない情報が外部に漏洩する可能性があるので
global_execution_handlerのレスポンスに含めてはいけないと思います。PresetManagerでファイルの書き込み時にFileNotFoundErrorを捕捉するようになっているがこれは発生しない気がする…