整理: EngineManifestJson を dataclass へ変更
#1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
そう･･･な気がしていますが、より機能を持ったBaseModelを使うのも悪くない気もしないでもないです。 |
|
最終形の議論 issue である #1405 にて回答しました。 |
|
#1405 の Go 判断に基づき draft を解除しました。レビューよろしくお願いします。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
#1405 に基づき
EngineManifestJsonをdataclassへ変更するリファクタリングを提案します。（追記: PR の妥当性は #1405 で議論）
関連 Issue
part of #1405