Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
概要: コアのディレクトリ設定と設定値利用を近くに配置
initialize_cores()
には音声ライブラリを指定するvoicelib_dirs
変数とランタイムを指定するruntime_dirs
変数がある。この 2 変数は
initialize_cores()
引数により値が変動するが、値設定が入り組んでおりパッと見て理解できない。この原因は
voicelib_dirs
とruntime_dirs
を同時並行で設定することに起因する。また
voicelib_dirs
の設定を利用が離れているため、影響範囲が関数全体であり得るため見通しが悪い。このような背景から、
voicelib_dirs
とruntime_dirs
を個別に設定し、かつ設定と利用を近接させるリファクタリングを提案します。関連 Issue
無し