Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

整理: e2e single API テスト vol 6 #1155

Merged
merged 5 commits into from
Apr 15, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented Mar 30, 2024

内容

副作用により disabled としていた e2e テストを、副作用の除去により enabled とした。
変更後のテスト実装状況は以下の通り:

  • GET /presets
    • 200 & snapshot
  • POST /add_preset
    • 200 & snapshot
  • POST /update_preset
    • 200 & snapshot
    • 422 & snapshot
  • POST /delete_preset
    • 200 & snapshot
    • 422 & snapshot

関連 Issue

part of #1065
successor of #1149

Notes

依存 issues

以下の issues / PRs に依存:

これら解決後に review 可能

@tarepan tarepan force-pushed the refactor/e2e_single_api_no_se branch from e6ef2a3 to e7df0c5 Compare April 9, 2024 04:35
Copy link

github-actions bot commented Apr 9, 2024

Coverage Result

Resultを開く
Name Stmts Miss Cover
run.py 517 192 coverage-63%
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/cancellable_engine.py 97 75 coverage-23%
voicevox_engine/core/init.py 0 0 coverage-100%
voicevox_engine/core/core_adapter.py 81 6 coverage-93%
voicevox_engine/core/core_initializer.py 60 30 coverage-50%
voicevox_engine/core/core_wrapper.py 228 160 coverage-30%
voicevox_engine/dev/init.py 0 0 coverage-100%
voicevox_engine/dev/core/init.py 0 0 coverage-100%
voicevox_engine/dev/core/mock.py 65 2 coverage-97%
voicevox_engine/dev/tts_engine/init.py 0 0 coverage-100%
voicevox_engine/dev/tts_engine/mock.py 28 0 coverage-100%
voicevox_engine/engine_manifest/EngineManifest.py 36 0 coverage-100%
voicevox_engine/engine_manifest/EngineManifestLoader.py 11 0 coverage-100%
voicevox_engine/engine_manifest/init.py 0 0 coverage-100%
voicevox_engine/library_manager.py 92 4 coverage-96%
voicevox_engine/metas/Metas.py 36 0 coverage-100%
voicevox_engine/metas/MetasStore.py 28 1 coverage-96%
voicevox_engine/metas/init.py 0 0 coverage-100%
voicevox_engine/model.py 180 3 coverage-98%
voicevox_engine/morphing.py 72 4 coverage-94%
voicevox_engine/preset/Preset.py 13 0 coverage-100%
voicevox_engine/preset/PresetError.py 2 0 coverage-100%
voicevox_engine/preset/PresetManager.py 82 2 coverage-98%
voicevox_engine/preset/init.py 0 0 coverage-100%
voicevox_engine/setting/Setting.py 9 0 coverage-100%
voicevox_engine/setting/SettingLoader.py 20 0 coverage-100%
voicevox_engine/setting/init.py 0 0 coverage-100%
voicevox_engine/tts_pipeline/init.py 0 0 coverage-100%
voicevox_engine/tts_pipeline/kana_converter.py 88 1 coverage-99%
voicevox_engine/tts_pipeline/mora_mapping.py 7 0 coverage-100%
voicevox_engine/tts_pipeline/phoneme.py 34 0 coverage-100%
voicevox_engine/tts_pipeline/text_analyzer.py 146 6 coverage-96%
voicevox_engine/tts_pipeline/tts_engine.py 268 9 coverage-97%
voicevox_engine/user_dict/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/user_dict/user_dict.py 146 12 coverage-92%
voicevox_engine/utility/init.py 0 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 37 0 coverage-100%
voicevox_engine/utility/core_utility.py 6 0 coverage-100%
voicevox_engine/utility/core_version_utility.py 8 1 coverage-88%
voicevox_engine/utility/mutex_utility.py 13 0 coverage-100%
voicevox_engine/utility/path_utility.py 26 6 coverage-77%
voicevox_engine/utility/run_utility.py 10 7 coverage-30%
TOTAL 2452 521 coverage-79%

@tarepan tarepan marked this pull request as ready for review April 9, 2024 04:49
@tarepan tarepan requested a review from a team as a code owner April 9, 2024 04:49
@tarepan tarepan requested review from Hiroshiba and removed request for a team April 9, 2024 04:49
test/e2e/conftest.py Outdated Show resolved Hide resolved
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@tarepan
Copy link
Contributor Author

tarepan commented Apr 10, 2024

@Hiroshiba
全指摘箇所の反映・テストパスを確認しました。Re-review よろしくお願いします。

@Hiroshiba
Copy link
Member

マージします!

@Hiroshiba Hiroshiba merged commit e5635cb into VOICEVOX:master Apr 15, 2024
3 checks passed
@tarepan tarepan deleted the refactor/e2e_single_api_no_se branch April 15, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants