-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
整理: e2e single API テスト vol 6 #1155
Merged
Hiroshiba
merged 5 commits into
VOICEVOX:master
from
tarepan:refactor/e2e_single_api_no_se
Apr 15, 2024
Merged
整理: e2e single API テスト vol 6 #1155
Hiroshiba
merged 5 commits into
VOICEVOX:master
from
tarepan:refactor/e2e_single_api_no_se
Apr 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarepan
force-pushed
the
refactor/e2e_single_api_no_se
branch
from
April 9, 2024 04:35
e6ef2a3
to
e7df0c5
Compare
Hiroshiba
reviewed
Apr 9, 2024
Hiroshiba
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
@Hiroshiba |
マージします! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
副作用により disabled としていた e2e テストを、副作用の除去により enabled とした。
変更後のテスト実装状況は以下の通り:
GET /presets
200
& snapshotPOST /add_preset
200
& snapshotPOST /update_preset
200
& snapshot422
& snapshotPOST /delete_preset
200
& snapshot422
& snapshot関連 Issue
part of #1065
successor of #1149
Notes
依存 issues
以下の issues / PRs に依存:
これら解決後に review 可能