Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
commented
Oct 6, 2024
| npm run latestDefaultEngineInfos | ||
| npm run generateLatestDefaultEngineInfos |
Hiroshiba
commented
Oct 6, 2024
Comment on lines
80
to
+82
| const GITHUB_RELEASES_URL = | ||
| "https://api.github.com/repos/VOICEVOX/voicevox_engine/releases" | ||
| const ENGINE_ID = "074fc39e-678b-4c13-8916-ffca8d505d1d" |
There was a problem hiding this comment.
Nemoの情報も含めても良さそうだけど、現状デフォルトエンジンとしてNemoが導入されていないので、まあいいかなと。
|
いや･･･デフォルトエンジンの情報ごとに、更新情報の URL を持てるようにしたほうが良いかも･･･････。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
の続きタスクです。
デフォルトエンジンは複数設定できるようになっているので、こちらの更新情報も複数設置できるようにしておく必要があることに気づきました。
ということでルート直下にエンジンIDを設定できるようにし、そのエンジン ID ごとにオブジェクトを1つ持てるようにしました。
データ構造的には階層が1つ増えただけです。
関連 Issue
その他