build下のスクリプトをtoolsに動かしてTypeScriptにする #2361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenc-nanashi
requested review from
Hiroshiba
and removed request for
a team
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
sevenc-nanashi
changed the title
Hiroshiba
reviewed
Nov 17, 2024
Closed
3 tasks
Hiroshiba
approved these changes
Nov 19, 2024
Comment on lines
-112
to
+115
| mkdirSync(TYPOS_BINARY_PATH, { recursive: true }); | ||
| await fs.mkdir(TYPOS_BINARY_PATH, { recursive: true }); |
There was a problem hiding this comment.
（ただのコメントです）
asyncな関数をawaitするより、syncな関数をそのまま使うほうが実は便利なのではとちょっと思ってたりします。
asyncが広まらないので。
|
あっすみません、コンフリクトの解消お願いしてもいいですか 🙇 |
|
マージしました。 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
build下のスクリプトをtoolsに動かします。
関連 Issue
（なし）
スクリーンショット・動画など
（なし）
その他
（なし）