Update python version and poetry installation path #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiliec
requested review from
asuleymanov,
bitphage,
On1x,
Lex-Ai and
denis-skripnik
bitphage
reviewed
Nov 8, 2023
.github/workflows/tests.yml
Outdated
|
|
||
| - name: Set up cache | ||
| uses: actions/cache@v1 | ||
| uses: actions/cache@v2 |
There was a problem hiding this comment.
No need for separate cache action, example:
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
cache: 'poetry'
pyproject.toml
Outdated
| toolz = "^0.10.0" | ||
| funcy = "^1.14" | ||
| docker = "^4.2.0" | ||
| python = "^3.10.0" |
There was a problem hiding this comment.
Generally libraries are trying to maintain compatibility with older python versions. In this case I'm not sure there are much clients to support.
pyproject.toml
Outdated
|
|
||
| [tool.poetry] | ||
| name = "viz-python-lib" | ||
| version = "0.1.0" | ||
| description = "python library for VIZ blockchain" | ||
| version = "0.2.0" |
There was a problem hiding this comment.
I suggest to bump to 1.0.0 as python version dep is increased, and maintain semantic versioning further.
bitphage
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.