Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump express from 4.17.1 to 4.18.2 #92

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/Constants/ControllerRating.php
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ public static function getRatingCodeByNumber(int $index): ?string

/**
* Get the human readable version of a given code.
*
* @param string $code
* @return string
*/
Expand Down
4 changes: 3 additions & 1 deletion app/GraphQL/Scalars/DateTimeZulu.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,9 @@ class DateTimeZulu extends ScalarType
/**
* Serialize an internal value, ensuring it is a valid datetime string.
*
* @param \Carbon\Carbon|string $value
* @param \Carbon\Carbon|string $value
* @return string
*
* @throws
*/
public function serialize($value): string
Expand All @@ -35,6 +36,7 @@ public function serialize($value): string
*
* @param mixed $value
* @return \Carbon\Carbon
*
* @throws
*/
public function parseValue($value): Carbon
Expand Down
31 changes: 17 additions & 14 deletions app/Modules/Availability/Mutations/AvailabilityHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,14 @@ class AvailabilityHandler
/**
* Return a value for the field.
*
* @param null $rootValue Usually contains the result returned from the parent field. In this case,
* it is always `null`.
* @param mixed[] $args The arguments that were passed into the field.
* @param GraphQLContext $context Arbitrary data that is shared between all fields of a single query.
* @param ResolveInfo $resolveInfo Information about the query itself, such as the execution state, the field name,
* path to the field from the root, and more.
* @param null $rootValue Usually contains the result returned from the parent field. In this case,
* it is always `null`.
* @param mixed[] $args The arguments that were passed into the field.
* @param GraphQLContext $context Arbitrary data that is shared between all fields of a single query.
* @param ResolveInfo $resolveInfo Information about the query itself, such as the execution state, the field name,
* path to the field from the root, and more.
* @return Availability
*
* @throws BindingResolutionException
*/
public function update($rootValue, array $args, GraphQLContext $context, ResolveInfo $resolveInfo)
Expand All @@ -39,12 +40,13 @@ public function update($rootValue, array $args, GraphQLContext $context, Resolve
* Return a value for the field.
*
* @param null $rootValue Usually contains the result returned from the parent field. In this case,
* it is always `null`.
* it is always `null`.
* @param mixed[] $args The arguments that were passed into the field.
* @param GraphQLContext $context Arbitrary data that is shared between all fields of a single query.
* @param ResolveInfo $resolveInfo Information about the query itself, such as the execution state,
* the field name, path to the field from the root, and more.
* the field name, path to the field from the root, and more.
* @return mixed
*
* @throws OverlappingAvailabilityException
* @throws BindingResolutionException
*/
Expand All @@ -60,13 +62,14 @@ public function create($rootValue, array $args, GraphQLContext $context, Resolve
/**
* Remove date range.
*
* @param null $rootValue Usually contains the result returned from the parent field. In this case,
* it is always `null`.
* @param mixed[] $args The arguments that were passed into the field.
* @param GraphQLContext $context Arbitrary data that is shared between all fields of a single query.
* @param ResolveInfo $resolveInfo Information about the query itself, such as the execution state,
* the field name, path to the field from the root, and more.
* @param null $rootValue Usually contains the result returned from the parent field. In this case,
* it is always `null`.
* @param mixed[] $args The arguments that were passed into the field.
* @param GraphQLContext $context Arbitrary data that is shared between all fields of a single query.
* @param ResolveInfo $resolveInfo Information about the query itself, such as the execution state,
* the field name, path to the field from the root, and more.
* @return mixed
*
* @throws BindingResolutionException
*/
public function remove($rootValue, array $args, GraphQLContext $context, ResolveInfo $resolveInfo)
Expand Down
9 changes: 5 additions & 4 deletions app/Modules/Availability/Services/AvailabilityService.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,12 @@ public function __construct(User $user)
/**
* Validate that two given times are valid within the context of other availability.
*
* @param Carbon $from
* @param Carbon $to
* @param User $user - User
* @param int $doNotCheck - Pass in an int to exclude from the search
* @param Carbon $from
* @param Carbon $to
* @param User $user - User
* @param int $doNotCheck - Pass in an int to exclude from the search
* @return bool
*
* @throws AvailabilityMinimumTimeException
* @throws AvailabilityInPastException
* @throws \Throwable
Expand Down
1 change: 1 addition & 0 deletions app/Modules/Bookings/Mutations/CreateBookingHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ class CreateBookingHandler
* @param GraphQLContext $context Arbitrary data that is shared between all fields of a single query.
* @param ResolveInfo $resolveInfo Information about the query itself.
* @return mixed
*
* @throws RatingRequirementNotMetException
* @throws SpecialEndorsementNotAttainedException
* @throws OverlappingBookingException
Expand Down
1 change: 1 addition & 0 deletions app/Modules/Bookings/Mutations/UpdateBookingHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ class UpdateBookingHandler
* @param mixed[] $args The arguments that were passed into the field.
* @param GraphQLContext $context Arbitrary data that is shared between all fields of a single query.
* @param ResolveInfo $resolveInfo Information about the query itself.
*
* @throws OverlappingBookingException
*/
public function __invoke($rootValue, array $args, GraphQLContext $context, ResolveInfo $resolveInfo)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ class GrantSoloEndorsementHandler
* @param mixed[] $args The arguments that were passed into the field.
* @param GraphQLContext $context Arbitrary data that is shared between all fields of a single query.
* @param ResolveInfo $resolveInfo Information about the query itself.
*
* @throws OverlappingBookingException
*/
public function __invoke($rootValue, array $args, GraphQLContext $context, ResolveInfo $resolveInfo)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ class GrantSpecialEndorsementHandler
* @param \Nuwave\Lighthouse\Support\Contracts\GraphQLContext $context Arbitrary data that is shared between all fields of a single query.
* @param \GraphQL\Type\Definition\ResolveInfo $resolveInfo Information about the query itself.
* @return mixed
*
* @throws EndorsementAlreadyGrantedException
*/
public function __invoke($rootValue, array $args, GraphQLContext $context, ResolveInfo $resolveInfo)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ public function __construct(User $user)
* @param \Nuwave\Lighthouse\Support\Contracts\GraphQLContext $context Arbitrary data that is shared between all fields of a single query.
* @param \GraphQL\Type\Definition\ResolveInfo $resolveInfo Information about the query itself.
* @return mixed
*
* @throws EndorsementRequestAlreadyExistsException
* @throws EndorsementAlreadyGrantedException
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ public function __construct(User $user)
* @param GraphQLContext $context Arbitrary data that is shared between all fields of a single query.
* @param ResolveInfo $resolveInfo Information about the query itself.
* @return mixed
*
* @throws \InvalidArgumentException
*/
public function __invoke($rootValue, array $args, GraphQLContext $context, ResolveInfo $resolveInfo)
Expand Down
24 changes: 12 additions & 12 deletions app/Modules/SessionRequest/SessionRequestService.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ public function __construct(BookingsService $bookingsService)
/**
* Creates a session request for a given user on a particular position.
*
* @param User $user
* @param Position $position
* @param User $user
* @param Position $position
* @return SessionRequest
*/
public function createSessionRequest(User $user, Position $position): SessionRequest
Expand All @@ -45,7 +45,7 @@ public function createSessionRequest(User $user, Position $position): SessionReq
/**
* Revokes a session request for a given session which hasn't been accepted.
*
* @param SessionRequest $sessionRequest
* @param SessionRequest $sessionRequest
* @return bool
*/
public function revokeSessionRequest(SessionRequest $sessionRequest): bool
Expand All @@ -58,13 +58,13 @@ public function revokeSessionRequest(SessionRequest $sessionRequest): bool
/**
* Accept a session request with the given times.
*
* @param SessionRequest $sessionRequest
* @param User $acceptingUser
* @param Carbon $sessionDateFrom
* @param Carbon $sessionDateTo
* @param Carbon $bookingDateFrom
* @param Carbon $bookingDateTo
* @param int $networkType
* @param SessionRequest $sessionRequest
* @param User $acceptingUser
* @param Carbon $sessionDateFrom
* @param Carbon $sessionDateTo
* @param Carbon $bookingDateFrom
* @param Carbon $bookingDateTo
* @param int $networkType
* @return SessionRequest
*/
public function acceptSessionRequest(
Expand Down Expand Up @@ -106,8 +106,8 @@ public function acceptSessionRequest(
/**
* Cancel a session request which has already been accepted.
*
* @param SessionRequest $sessionRequest
* @param string $reason
* @param SessionRequest $sessionRequest
* @param string $reason
* @return SessionRequest
*/
public function cancelSession(SessionRequest $sessionRequest, string $reason): SessionRequest
Expand Down
4 changes: 2 additions & 2 deletions app/Rules/UserExistsRule.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ class UserExistsRule implements Rule
/**
* Determine if the validation rule passes.
*
* @param string $attribute
* @param mixed $value
* @param string $attribute
* @param mixed $value
* @return bool
*/
public function passes($attribute, $value)
Expand Down
1 change: 1 addition & 0 deletions tests/Feature/Booking/BookingCreateTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,7 @@ public function testItCanDeleteABooking()

/**
* Setup a test case to pass the rating check for testing overlapping.
*
* @param string $callsign
*/
private function bypassRatingChecks($callsign = 'EGGD_TWR')
Expand Down
Loading