Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter shows by watch provider #969

Merged
merged 32 commits into from
Feb 23, 2024
Merged

Filter shows by watch provider #969

merged 32 commits into from
Feb 23, 2024

Conversation

UweTrottmann
Copy link
Owner

@UweTrottmann UweTrottmann commented Jan 19, 2024

#968

Initial goal: proof of concept.

If finalizing:

  • Add provider mappings when adding/updating shows.
  • Update providers when syncing? They should not change that often.
  • Action to remove all provider filters, also from empty view.
  • Action to configure streaming search region.
    • Update providers and mappings after changing region?
  • Use database instead of on-demand data for stream search buttons.
    • TMDB response cache expires after 6 hours for per-show providers, after 3 hours for all providers.
  • Database migration test
  • Verify auto-sizing of WrappingViewPager continues to work.
    • Issue: ViewPager adds children with match_parent. // Moved away from pager, at the downside of loosing swiping.
    • ComposeView height needs to adapt to max available height (defaultMinSize does not work, still infinite height).
    • Move ScrollView down to each page view.
  • Debounce shows query? Check how often it is initially run.
  • Test database upgrade on device

@UweTrottmann UweTrottmann force-pushed the 968-more-filter-options branch 2 times, most recently from 3b2f05b to b925725 Compare February 2, 2024 12:05
@UweTrottmann UweTrottmann force-pushed the 968-more-filter-options branch 2 times, most recently from 0e8e024 to 5e202cc Compare February 16, 2024 17:46
@UweTrottmann UweTrottmann force-pushed the 968-more-filter-options branch from 8ddf0bc to 2f18b2a Compare February 22, 2024 12:03
@UweTrottmann UweTrottmann force-pushed the 968-more-filter-options branch from f53a9a7 to ed27d07 Compare February 23, 2024 08:39
@UweTrottmann UweTrottmann marked this pull request as ready for review February 23, 2024 10:35
@UweTrottmann UweTrottmann added this to the SeriesGuide 72 milestone Feb 23, 2024
@UweTrottmann UweTrottmann merged commit f49a7fd into dev Feb 23, 2024
5 checks passed
@UweTrottmann UweTrottmann deleted the 968-more-filter-options branch February 23, 2024 15:40
@MicLieg
Copy link

MicLieg commented Mar 10, 2024

@UweTrottmann
Thank you so much for implementing this feature and prioritising it as much as you have! I've just tested it and it's extremely helpful!

Thanks again for all your hard work!

@UweTrottmann
Copy link
Owner Author

Thanks, I'm glad you find it to be useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants