Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make email optional on customer update #24

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make email optional on customer update #24

wants to merge 3 commits into from

Conversation

scottsb
Copy link

@scottsb scottsb commented Jan 24, 2018

Don't require email to be sent on a customer update request. With the API, if you have the ID, it is possible to update attributes without having to specify email, so that should be allowed here as well.

@scottsb
Copy link
Author

scottsb commented Jan 24, 2018

The change to Api.php is probably unnecessary. They key part is just not forcing email to be in the JSON sent in the API call.

peter279k
peter279k reviewed Aug 31, 2019
View reviewed changes
Copy link

@peter279k peter279k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.

Could you have some tests about these code changes?

It will make sure that the behavior will be expected.

@scottsb
Copy link
Author

scottsb commented Jan 1, 2020

Better late than never. 😄Just pushed up a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peter279k peter279k peter279k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottsb @peter279k