feat: serverside pagination for the questions table done #836
Conversation
yoganandaness
requested review from
RasmiaKulan and
janosbabik
and removed request for
a team
…ion-and-query-para
…ion-and-query-para
…ion-and-query-para
…ion-and-query-para
There was a problem hiding this comment.
This looks great. I did notice though that when trying to sort by number of answers or number of templates an error is thrown. It looks like the value passed as sortField is either answerCountButton or templateCountButton, neither of which are in fieldMap. Could this please be addressed? I understand the reasoning behind putting paginated table tests in a different PR but perhaps this should wait until the tests are ready? Would like to hear people's thoughts.
…re into SWAP-4232-uo-question-page-server-pagination-and-query-para
Thanks for the comment @Scott-James-Hurley. I have fixed the issue with sorting the column of Answers count and Templates count. Also, as you mentioned, it is a good idea to wait for the test cases before merging the PR. I am expecting to write the test cases for these next week. Will club these together. Until then, moving this to Draft. |
There was a problem hiding this comment.
@yoganandaness I really like the PR, especially the frontend part 👍🏻
I just left a comment one for the backed but looks good so I can already approve it, or is this still in draft?
| public dataType?: DataType[]; | ||
|
|
||
| @Field(() => [DataType], { nullable: true }) | ||
| public excludeDataType?: DataType[]; |
There was a problem hiding this comment.
question: It appears that the excludeDataType is not used? Shall we remove it then?
@yoganandaness |
…ion-and-query-para
|
When accessing the questions table I get the following error: |
Description
Serverside Pagination for the questions table
Motivation and Context
Improve performance in the questions table
How Has This Been Tested
Manually. Test cases also have been updated. Extensive test case for server side pagination need to be done in a separate task.
Fixes
Changes
Backend query change to facilitate serverside pagination.
Depends on
Tests included/Docs Updated?