fix: inject and optional decorators should allow key to be undefined #2329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Typescript 5 has tighter parameter decorator checking with --experimentalDecorators.
That means constructor parameter decorators should allow undefined as the type of key.
Fixes # (issue)
Type of change
Screenshots/Sandbox (if appropriate/relevant):
How Has This Been Tested?
I've tested patched graphql-modules in a project that makes use of TS5 and the
Inject
decorator.Test Environment:
graphql-modules
: 2.1.1Checklist:
Further comments