Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creates rawphenotypes germplasm field #88
Creates rawphenotypes germplasm field #88
Changes from 5 commits
d5f9ff4
fe6bc13
5541a67
158c27e
6437f82
6fa0ccc
5dfbe83
1f872cc
6dc7913
b640548
5699d36
c666964
3af2452
3ef128b
a7061c6
755be53
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels very pre-formatted for what you want in the formatter. It should likely be broken out into a nested array with cvterm keys and then compiled to this format in the formatter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the value should not be keyed by the field name. Also, you should always use the new array notation:
[ ]
rather than the old style for PHP compatibility reasons.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the keys exposed through the value should be cvterms and should only represent data. The icons feel out of place here as it relates to the format, not the data. All sub-keys as well so the counts in the summary should also have cvterms as keys.