Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: migration guide for v6 #204

Closed
wants to merge 44 commits into from
Closed

docs: migration guide for v6 #204

wants to merge 44 commits into from

Conversation

sighphyre
Copy link
Member

@sighphyre sighphyre commented Sep 25, 2024 •
edited
Loading

Migration guide for moving to v6. Turns out evaluations between Yggdrasil base and the Ruby SDK are already identical insofar as I can tell so no changes there

This really wants #152 to get merged before looking this over

@sighphyre
feat: splat apply patch from local work
fb3bdf8
@sighphyre
chore: hack in local path for yggdrasil
eec8121
@sighphyre
chore: trim out diff that shouldn't have been checked in
61ad46c
@sighphyre
wip: implement custom strategies, this definitely needs a rebase
5797508
@sighphyre
green tests!
4b3a598
@sighphyre
chore: use published package rather than a symlink
211fcdf
@sighphyre
chore: merge main
6382a94
@sighphyre
wip: trim some unneeded strings and apply format
a0707de
@sighphyre
wip: trim some unneeded nil checks
c39fe95
@sighphyre
wip: move default_variant to Variant
5df5067
@sighphyre
wip: more null checks removed
f6071b9
@sighphyre
wip: make internal public api for custom strategies match existing api
88b46c7
@sighphyre
wip: remove class and references to FeatureToggle.default_variant
7f55e6b
@sighphyre
wip: remove new log message
5851724
@sighphyre
wip: bring custom strategies closer to existing api
49925d5
@sighphyre
wip: remove unused parameters and functions and take rubocop suggestion
0116bef
@sighphyre
wip: remove :toggles, :toggle_metrics, and :segment_cache from Unleas…
766d392 
…h namespace and remove usage of these throughout the bodebase
@sighphyre
wip: refactor get_variant method and restore logging
6530299
@sighphyre
chore: apply some rubocop lints
c367b0b
@sighphyre
wip: minor refactor to toggle fethcer
1cd34b2
@sighphyre
wip: bump yggdrasil
5b5bb20
@sighphyre
wip: merge main
aaa6b0f
@sighphyre
chore: bump ygg version
8f0c038
@sighphyre
wip: include version of ygg that contains gem for jruby9.2
3122986
@sighphyre
chore: bump ygg to a version that should include macos universal arti…
3e44bc3 
…facts
@sighphyre
chore: bump yggdrasil version
05c83ce
@sighphyre
chore: bump ygg again
e0d37af
@sighphyre
chore: exclude spec folder in coveralls
156356c
@sighphyre
chore: remove variant override, don't need it anymore
9be1f29
@sighphyre
chore: disable some coverage that I don't think makes sense
8e64f84
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11031869423

Details

  • 73 of 74 (98.65%) changed or added relevant lines in 8 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-1.7%) to 95.57%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/unleash/context.rb 21 22 95.45%
Files with Coverage Reduction New Missed Lines %
lib/unleash/scheduled_executor.rb 1 95.12%
lib/unleash/toggle_fetcher.rb 2 93.22%
lib/unleash/client.rb 3 87.76%
Totals Coverage Status
Change from base Build 10989234515: -1.7%
Covered Lines: 453
Relevant Lines: 474
💛 - Coveralls

@sighphyre
Copy link
Member Author

Closing this so I can redo this from the main repo not a fork

@sighphyre sighphyre closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sighphyre @coveralls