Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not fail when case insentive enabled while having a complex context object #191

Merged
merged 7 commits into from
Aug 29, 2024
Merged

fix: do not fail when case insentive enabled while having a complex context object #191

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
51b8ec3
Test that validates the failure
gastonfournier Aug 28, 2024
694c94b
Lint
gastonfournier Aug 28, 2024
62b0bfd
Implement tests in rspec
gastonfournier Aug 28, 2024
0076e2d
fix: validate is string before upcase
gastonfournier Aug 28, 2024
c2a1a09
chore: return false when string operation is applied to non string co…
gastonfournier Aug 28, 2024
49e2524
Remove trailing spaces
gastonfournier Aug 28, 2024
811822f
Simplify and avoid modifying the context value (#192)
gastonfournier Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/unleash/constraint.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ def matches_constraint?(context)
context_value = context.get_by_name(self.context_name)
gastonfournier marked this conversation as resolved.
Show resolved Hide resolved

v.map!(&:upcase) if self.case_insensitive
context_value = context_value.upcase if self.case_insensitive
context_value = context_value.upcase if self.case_insensitive && context_value.is_a?(String)
gastonfournier marked this conversation as resolved.
Show resolved Hide resolved

OPERATORS[self.operator].call(context_value, v)
end
Expand Down
Loading