chore: centralize client spec info #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age still in flight
sighphyre
force-pushed
the
chore/centralize-client-spec-info
branch
from
e4cbc70 to
8f98bef
Compare
sighphyre
force-pushed
the
chore/centralize-client-spec-info
branch
from
1b47e4d to
cdbbd44
Compare
…to run when the tests are present instead of when theyre not
…unning tests without the client spec
sighphyre
commented
Jul 4, 2024
| state_segments = state.fetch('segments', []).map{ |segment| [segment["id"], segment] }.to_h | ||
| let(:unleash_toggles) { state_features } | ||
| unleash_client = Unleash::Client.new | ||
| unless File.exist?(SPECIFICATION_PATH + '/index.json') |
There was a problem hiding this comment.
This looks like a big change, it's 99% whitespace. All this does is make the tests fail instead of warn if the client spec isn't present
Pull Request Test Coverage Report for Build 9793287416Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9793316835Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd be pretty cool to have the required semver for the client-specification as a single source of truth. This PR makes that happen by encoding it in the gemspec file.
This is part of the move towards a more standardized set of metrics across all of our SDKs - I could just hard code it but that information will drift and it actually needs to be accurate for Unleash to function properly.
As a part of this I've made the client-specification necessary for a successful test run. Currently leaving this in draft while I test the build but I'll put a nicer set of instructions in place before I move to ready for review