Unleash::Context#to_s displays all properties

[nissyi-gh]

About the changes

• Refactored the to_s method in the Context class to dynamically include all instance variables.
• This change ensures that any new instance variables added in the future will automatically be included in the string representation without needing to modify the to_s method.
• This makes the method more flexible and maintainable.

RSpec and RuboCop were executed, and no issues were found related to this change.

Closes #172

Important files

• lib/unleash/context.rb

Discussion points

• None at this time.

[rarruda]

I would have preferred a simpler approach, without meta-programming.

Also, as in all other classes in the entire project, we do not use meta programming when writing the to_s method, and I would like to stick to that standard, instead of having different implementations in different classes.

I would however be positive to having meta programming in a test to verify that all instance variables are present in the to_s method, if you feel like doing that.

Or if using meta programming, leverage the built-in to_h built in method (as in the suggestion below).

[rarruda]

If one were to use meta-programming, i'd have preferred if the built in to_h method was used instead:

Suggested change

	formatted_attributes = instance_variables.map do |var|
	"#{var.to_s.delete('@')}=#{instance_variable_get(var)}"
	end
	"<Context: #{formatted_attributes.join(', ')}>"
	"<Context: " + self.to_h.map{|k,v| "#{k}=#{v}"}.join(',') + ">"

[nissyi-gh]

I had no idea to use the to_h method. It is a very nice and simple implementation!

[coveralls]

Pull Request Test Coverage Report for Build 9600614573

Details

• 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.002%) to 97.131%

---

Totals
Change from base Build 9594960976:	0.002%
Covered Lines:	2539
Relevant Lines:	2614

---

💛 - Coveralls

[nissyi-gh]

@rarruda Thank you for your review!

I learned that I should refer to implementations in other classes. I also felt that a simpler implementation without meta-programming would be better.

[nissyi-gh]

I have confirmed once again that the RSpec and RuboCop checks pass.

[coveralls]

Pull Request Test Coverage Report for Build 9624141809

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 97.129%

---

Totals
Change from base Build 9594960976:	0.0%
Covered Lines:	2537
Relevant Lines:	2612

---

💛 - Coveralls

[rarruda]

Thanks for your contribution and for making the unleash gem better!