test: what happens if longest without a report is false

Unleash · Dec 10, 2024 · 2946ca7 · 2946ca7
1 parent 59bc154
commit 2946ca7
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/lib/unleash/feature_toggle.rb b/lib/unleash/feature_toggle.rb
diff --git a/lib/unleash/metrics_reporter.rb b/lib/unleash/metrics_reporter.rb
@@ -32,7 +32,7 @@ def post
       Unleash.logger.debug "post() Report"
 
       bucket = self.generate_report
-      if bucket.nil? && (Time.now - self.last_time < LONGEST_WITHOUT_A_REPORT) # and last time is less then 10 minutes...
+      if bucket.nil? && (false && Time.now - self.last_time < LONGEST_WITHOUT_A_REPORT) # and last time is less then 10 minutes...
         Unleash.logger.debug "Report not posted to server, as it would have been empty. (and has been empty for up to 10 min)"
 
         return

diff --git a/spec/unleash/metrics_reporter_spec.rb b/spec/unleash/metrics_reporter_spec.rb
@@ -60,6 +60,19 @@
     )
   end
 
+  it "generates the correct report with no metrics" do
+    Unleash.configure do |config|
+      config.url      = 'http://test-url/'
+      config.app_name = 'my-test-app'
+      config.instance_id = 'rspec/test'
+      config.disable_client = true
+    end
+    Unleash.engine = YggdrasilEngine.new
+
+    report = metrics_reporter.generate_report
+    expect(report).to be_nil
+  end
+
   it "sends the correct report" do
     WebMock.stub_request(:post, "http://test-url/client/metrics")
       .with(