Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Frontend] Added env variable for sisu url and changed to use that instead of hardcoded sisu urls #4711

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[Frontend] Added env variable for sisu url and changed to use that instead of hardcoded sisu urls #4711

wants to merge 3 commits into from
+14 −7

Conversation

mattirasanen
Copy link
Collaborator

  • Added variable sisUrl in conf to use new env variable REACT_APP_SIS_URL if found else using hy sisu url like previously
  • Replaced hardcoded sisu urls to use sisUrl from config

@mattirasanen mattirasanen added the DON'T MERGE BEFORE FD APPROVAL Do not merge until Funidata has removed this label label Jan 7, 2025
@mattirasanen mattirasanen requested a review from EssKayz January 7, 2025 14:20
EssKayz
EssKayz reviewed Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@EssKayz EssKayz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FD Approved

@mattirasanen mattirasanen removed the DON'T MERGE BEFORE FD APPROVAL Do not merge until Funidata has removed this label label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EssKayz EssKayz EssKayz left review comments

@valtterikantanen valtterikantanen Awaiting requested review from valtterikantanen

@rikurauhala rikurauhala Awaiting requested review from rikurauhala

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattirasanen @EssKayz