Fix format in wholeImageHighResLabel when using version 3 manifests #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you use a version 3 manifest, then the format shown next to download option `Whole image w x h (?)` shows a `?`. This is because the code tries to load the image resource the way it is done in version 2. I added code for version 3 to derive the format Apparently not a problem for wholeImageLowResLabel
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Thanks, @nicolasfranck -- this looks reasonable to me and seems unlikely to introduce any breaking changes. My only question is whether this logic should instead be incorporated into Manifesto in some way to push the implementation details into a lower layer and help keep the UV more abstract. But if nobody has opinions about this, maybe the best thing would be to merge as-is now and refactor later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you use a version 3 manifest,
then the format shown next to download option
Whole image w x h (?)shows a?. This is because the code tries to load the image resource the way it is done in version 2.I added code for version 3 to derive the format
Apparently not a problem for wholeImageLowResLabel
Description of what you did: