-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UV controls scale improperly for audio manifests without ranges #944
Comments
So just skipping the media element extension, as in @benwbrum's PR above, introduces CORS issues:
(This is true for media at multiple sites, including Internet Archive which usually is wide open.) We're not sure why. Any ideas? |
The CORS issue above appears to be irrelevant. |
UV version: 4.0.22
I'm submitting a:
Current behavior:
When playing a single audio file, users generally want the UV control to be smallish--120-200 pixels high--since there is no video to display and no navigation needed. When loading a IIIF manifest without ranges containing only audio content, the player controls (play, next, volume, etc) scale down to the height of the div, making them appear to be tiny.
Example:
Expected behavior:
The controls should not scale down, but rather appear at the full width of the player.
Steps to reproduce:
Load this manifest in a div sized at 180px: https://saracarl.github.io/comparison-test/her-kind/manifest.json
Related code:
According to discussion on UV Slack, this is caused by some special handling for range-less audio content:
Unfortunately, this work-around only works for manifests that contain ranges, so it is not universal.
The text was updated successfully, but these errors were encountered: