Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS problems after shipping UV in AA Theme #293

Open
saracarl opened this issue Nov 3, 2023 · 1 comment
Open

CORS problems after shipping UV in AA Theme #293

saracarl opened this issue Nov 3, 2023 · 1 comment

Comments

@saracarl
Copy link
Collaborator

saracarl commented Nov 3, 2023

Recent changes where we ship the UV javascript code as part of the AA Theme instead of referencing a content deliver network (CDN) for UV has led to CORS issues and audio not playing on:

https://tanyaclement.github.io/znh_jacksonville_1939/s1576-t86-243-june-18-1939-/

I reproduced this in our dupe project here: https://benwbrum.github.io/znh_rebuild/s1576-t86-243

We should:

  1. build and run the dupe project locally and see if the problem still happens
  2. likely switch the theme back to using the older UV on the CDN (controls will not look good)
  3. Talk to the UV folks to get them to make our change in a version of UV that's available via CDN
@saracarl
Copy link
Collaborator Author

saracarl commented Nov 8, 2023

We resolved this by rolling back to the published version of UV that has squished controls in smaller divs. We should watch this issue in UV:
UniversalViewer/universalviewer#944
When it's resolved, we can upgrade and hopefully have un-squished controls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant