Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

55 ipfs file uploader #58

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

55 ipfs file uploader #58

wants to merge 8 commits into from

Conversation

crackdev01
Copy link

No description provided.

@crackdev01 crackdev01 linked an issue Jun 23, 2023 that may be closed by this pull request
4 tasks
@crackdev01 crackdev01 requested review from stojanov-igor and slaveatanasov and removed request for slaveatanasov June 23, 2023 15:19
Copy link
Member

@stojanov-igor stojanov-igor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are appending .txt to the downloaded files (QmWBXoQ9qyaNXDiXfWAvEypY4we6Z2AZFKJ8yzoydSfZsV.txt) which is not correct. The downloading does not work for me. Can you please fix this? Uploading seems to work correctly, but download is not working.

Also, can you add unit test/integration tests for the new functionality? We already have Cypress setup, so you can use it to test that the upload/download works correctly.

It is nice that you have covered the stretch goal. Nice Job. The download icon is too big, can you make it a bit smaller?

@crackdev01
Copy link
Author

What's your IPFS server URL ?

  • AWS: 52.91.119.196:8080 in the issue assigned to me

Make the connection to IPFS nodes configurable, instead of hardcoded. For example, we should be able to fetch files from the IPFS instance we have running at AWS: 52.91.119.196:8080
52.91.119.196:8080/ipfs/QmcDge1SrsTBU8b9PBGTGYguNRnm84Kvg8axfGURxqZpR1

  • REACT_APP_IPFS_URL=http://109.235.70.27:5001 in .env.development file of the project

If the URL is AWS: 52.91.119.196:8080, is running the AWS server?

@crackdev01 crackdev01 requested a review from stojanov-igor June 29, 2023 23:42
@stojanov-igor stojanov-igor added the enhancement New feature or request label Jul 17, 2023
@stojanov-igor stojanov-igor added this to the Release 1.0 milestone Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

IPFS file Uploader
2 participants