Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Updated music volume and sfx volume values passed on setup #517

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Bugfix] Updated music volume and sfx volume values passed on setup #517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions UOP1_Project/Assets/Scripts/Systems/Settings/UISettingsAudioComponent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ private void OnEnable()
}
private void OnDisable()
{
ResetVolumes(); // reset volumes on disable. If not saved, it will reset to initial volumes.
ResetVolumes(); // reset volumes on disable. If not saved, it will reset to initial volumes.
_musicVolumeField.OnNextOption -= IncreaseMusicVolume;
_musicVolumeField.OnPreviousOption -= DecreaseMusicVolume;
_saveButton.Clicked -= SaveVolumes;
Expand All @@ -52,8 +52,8 @@ private void OnDisable()
public void Setup(float musicVolume, float sfxVolume, float masterVolume)
{
_masterVolume = masterVolume;
_musicVolume = sfxVolume;
_sfxVolume = musicVolume;
_musicVolume = musicVolume;
_sfxVolume = sfxVolume;

_savedMasterVolume = _masterVolume;
_savedMusicVolume = _musicVolume;
Expand Down