View-only quoter #296
Closed
View-only quoter #296
+457
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saucepoint
reviewed
Aug 14, 2024
Comment on lines
+32
to
+38
| function nextInitializedTickWithinOneWord( | ||
| IPoolManager poolManager, | ||
| PoolId poolId, | ||
| int24 tickSpacing, | ||
| int24 tick, | ||
| bool lte | ||
| ) internal view returns (int24 next, bool initialized) { |
There was a problem hiding this comment.
it bothers me that we need to re-implement this again in periphery. Here's a draft PR on core which makes the library usable by periphery
Comment on lines
+11
to
+20
| /// @param poolKey The poolKey identifying the pool traded against | ||
| /// currency0 | ||
| /// currency1 | ||
| /// fee | ||
| /// tickSpacing | ||
| /// hooks | ||
| /// @param swapParams The parameters used for the swap | ||
| /// zeroForOne | ||
| /// amountSpecified | ||
| /// sqrtPriceLimitX96 |
There was a problem hiding this comment.
have we conventionally done natspec like this for struct params :thonk:
| function quote(IPoolManager poolManager, PoolKey calldata poolKey, IPoolManager.SwapParams calldata swapParams) | ||
| internal | ||
| view | ||
| returns (int256 amount0, int256 amount1, uint160 sqrtPriceAfterX96, uint32 initializedTicksCrossed) |
There was a problem hiding this comment.
optional but I like the idea of making the return type a BalanceDelta 😎
snreynolds
added
the
revisit
|
Closing this for now, and will follow up depending on needs for a view only quoter. Thanks for the contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Current quoter simulates a swap and reverts, using a lot of gas.
Description of changes
This view-only quoter aims to quote a v4 pool cheaper by removing the revert and the unused state updates. Currently, this can only quote swaps without hook executions that change the output of a swap.
This code is adapted from view-quoter-v3.