Mixed route v4 tests #374
Open
Mixed route v4 tests #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snreynolds
reviewed
Aug 19, 2024
| }) | ||
|
|
||
| describe('Interleaving routes', () => { | ||
| describe.only('Interleaving routes', () => { |
| v3AmountIn, | ||
| v3AmountOutMin, | ||
| encodePathExactInput(v3Tokens), | ||
| SOURCE_MSG_SENDER, // the user pays for the input of the v3 trade |
There was a problem hiding this comment.
its just a boolean (like in v4) called payerIsUser. So SOURCE_MSG_SENDER == true and SOURCE_ROUTER == false
There was a problem hiding this comment.
doesnt let you pull from any address
marktoda
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.