Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use Permit2 public repo in git submodules #204

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

rileydcampbell
Copy link
Contributor

No description provided.

@snreynolds
Copy link
Member

this looks like you deleted then readded permit2?

@rileydcampbell
Copy link
Contributor Author

rileydcampbell commented Sep 26, 2023

this looks like you deleted then readded permit2?

@snreynolds So one of our integrators was having an issue with using SSH to install these dependencies. Is there a reason we are using [email protected]:Uniswap/permit2.git instead of https://github.com/Uniswap/permit2?

@snreynolds
Copy link
Member

this looks like you deleted then readded permit2?

@snreynolds So one of our integrators was having an issue with using SSH to install these dependencies. Is there a reason we are using [email protected]:Uniswap/permit2.git instead of https://github.com/Uniswap/permit2?

gotcha, no thats fine, i think forge install doesnt use ssh so this is correct

@rileydcampbell rileydcampbell merged commit 3714628 into main Sep 26, 2023
2 checks passed
@rileydcampbell rileydcampbell deleted the use_permit_2_public_repo branch September 26, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants