refactor: add BaseExecutor with built in permit #202
Conversation
zhongeric
changed the title
.forge-snapshots/SwapRouter02ExecutorExecuteAlreadyApproved.snap
Outdated
Show resolved
Hide resolved
|
|
||
| function reactorCallback(ResolvedOrder[] calldata, bytes calldata callbackData) external virtual; | ||
|
|
||
| function execute(SignedOrder memory order, bytes memory callbackData) external payable { |
There was a problem hiding this comment.
should these be onlyOwner?
There was a problem hiding this comment.
mmm i thought we wanted execute to be gated by onlyWhitelstedCaller?
| /// @inheritdoc IReactorCallback | ||
| function reactorCallback(ResolvedOrder[] calldata, bytes calldata callbackData) external virtual; | ||
|
|
||
| function execute(SignedOrder memory order, bytes memory callbackData) public payable virtual { |
There was a problem hiding this comment.
made this virtual so we can add the onlyWhitelistedCaller modifier to it
There was a problem hiding this comment.
not a huge fan of this auth scheme, especially for reactorCallback because that must be restricted to only being called by the reactor but since its virtual in this base executor we can't enforce that here. So it's possible that integrators could make the mistake of not gating it by caller
There was a problem hiding this comment.
yep, discussed offline and we should remove impl here and just override in inheriting contract
| /// @inheritdoc IReactorCallback | ||
| /// @dev any overriding function MUST use the onlyReactor modifier | ||
| function reactorCallback(ResolvedOrder[] calldata, bytes calldata) external virtual onlyReactor {} |
There was a problem hiding this comment.
Since solidity doesn't require an overriding function to use the same modifier, I'm tempted to have this base contract not inherit the IReactor interface entirely and leave that up to integrations
|
closing as current preference is for fillers to do this in their fill contract |
SwapRouter02Executor now inherits BaseExecutor which adds a new entrypoint
multicallwhich allows callers to chain together series of execute and permit calls.