fix: enforce dutch decay actually decays #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there was ambiguous undefined behavior for if startTime and endTime were the same - This commit removes that ambiguity by enforcing startTime !== endTime
hensha256
approved these changes
Aug 22, 2023
marktoda
added a commit
that referenced
this pull request
Dec 18, 2023
* fix: typos (#190) This commit fixes a couple typos. Fixes: N-03 * feat: remove native transfer gas limit (#189) Gas limit for native transfer can cause some reasonable smart contract wallets that perform operations in their receive function to be unable to receive native output from uniswapX. compatibilty preferred here Resolves M-02 * fix: remove unused imports (#191) Fixes: N-02 * fix: documentation (#193) Fixes: L-05 * fix: Add missing natspec (#192) Fixes: L-04 * fix: enforce dutch decay actually decays (#194) Previously there was ambiguous undefined behavior for if startTime and endTime were the same - This commit removes that ambiguity by enforcing startTime !== endTime * fix: magic number documentation (#196) document magic numbers in orderquoter Fixes: L-08 * feat: improve test coverage (#197) * Remove unused return param names (#199) * Remove unused return names * Update OrderQuoter.sol * fix: fmt --------- Co-authored-by: Alice <[email protected]>
marktoda
added a commit
that referenced
this pull request
Jan 23, 2024
* fix: typos (#190) This commit fixes a couple typos. Fixes: N-03 * feat: remove native transfer gas limit (#189) Gas limit for native transfer can cause some reasonable smart contract wallets that perform operations in their receive function to be unable to receive native output from uniswapX. compatibilty preferred here Resolves M-02 * fix: remove unused imports (#191) Fixes: N-02 * fix: documentation (#193) Fixes: L-05 * fix: Add missing natspec (#192) Fixes: L-04 * fix: enforce dutch decay actually decays (#194) Previously there was ambiguous undefined behavior for if startTime and endTime were the same - This commit removes that ambiguity by enforcing startTime !== endTime * fix: magic number documentation (#196) document magic numbers in orderquoter Fixes: L-08 * feat: improve test coverage (#197) * Remove unused return param names (#199) * Remove unused return names * Update OrderQuoter.sol * fix: fmt * fix: tests * fix: lint * fix: typos * fix: revert if decay times are equal * fix: check for 0 address signer * fix: remove old exclusivityOverride for now * feat: add tests for override and cosigner * fix: ensure output overrides length is correct * feat: tests with successful override * feat: flatten v2 struct This commit flattens the V2 struct to maintain the reactor interface requirement that OrderInfo should be first struct so integrations like quoters can reliably fetch the reactor address and other order info fields Also saves a decent amt of gas from less encoding/decoding * fix: cleaup * fix: tests overrides --------- Co-authored-by: Alice <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there was ambiguous undefined behavior for if startTime and
endTime were the same - This commit removes that ambiguity by enforcing
startTime !== endTime