-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure every account has exactly one default dashboard #3236
Ensure every account has exactly one default dashboard #3236
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Test results 9 files 9 suites 8m 54s ⏱️ Results for commit 0071357. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3236 +/- ##
=======================================
Coverage 60.30% 60.30%
=======================================
Files 605 605
Lines 43685 43685
Branches 48 48
=======================================
Hits 26343 26343
Misses 17330 17330
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
im guessing the title should be renamed to
|
-- This migration is to ensure that for accounts that don't have a default | ||
-- dashboard we set a default dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just leaving a quick comment before the weekend: This is the weakness of NAV's homegrown migration system: This migration file will conflict with #3231. One of us needs to change our PR accordingly :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, let's see who it will be 😅
de748d8
to
0071357
Compare
Quality Gate passedIssues Measures |
Another part of fixing #3150.
As mentioned in there it is possible to delete ones default dashboard and no other is set to be default instead, essentially meaning a user can have no default dashboards. We also observed that it has somehow been possible to set multiple dashboards as default (see #2680), we still don't know how that has been possible and if it is still possible.
This PR adds two migrations:
Since it has not been possible to delete the last dashboard (as seen in #3232) we can assume that each account has at least one dashboard.