Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/IAMSE-1531 #3

Open
wants to merge 142 commits into
base: 2.6-externalauth
Choose a base branch
from
Open

feature/IAMSE-1531 #3

wants to merge 142 commits into from

Conversation

chasegawa
Copy link

Code preview of changes to make the external authorization workable in the plugin pattern

scalding and others added 3 commits November 9, 2021 08:57
@scalding
[IGA-417]
45a956f 
fix call to `getMemberships` with proper parameter
@chasegawa
IAMSE-1531
be96365 
updating pom with new parent
@chasegawa
IAMSE-1531
605c925 
refactored code to be accessed plugin style
@chasegawa chasegawa requested a review from scalding April 1, 2022 22:10
@chasegawa chasegawa self-assigned this Apr 1, 2022
@chasegawa
IAMSE-1531
1872da5 
initialing the config
@chasegawa
Copy link
Author

In the GROUPER core:

  • CommonServletContainerInitializer will (first) initialize the external auth filters (if the configuration is enabled).
  • External auth filters are simple delegates that will use the plugin manager to get the correct delegate classes
  • If the plugin is missing or mis-configured, the delegate filters should not impact anything - they will default to pass-through behavior
  • added additional properties to the grouper.base.properties (commented out examples). This does not replace or include the actual external authentication properties, just the PLUGIN needed properties

In the grouper-authentication:

  • eliminated the configuration class and moved the timer behavior to initialization within each of the FilterDecorators
  • Two FilterDecorators: one each for Security and Callback. The decorators decorate the filters with the re-initialization behavior

mchyzer and others added 4 commits April 3, 2022 19:15
@mchyzer
GRP-2027: Provide expression support for LDAP filters
ce284c6
@mchyzer
entity and membership attribute values
e6e4625
@mchyzer
progress on provisioning refactor
716006c
@chasegawa
IAMSE-1531
e65d77e 
Refactored packages.
Update to pom and added additional pom file following plugin packaging instructions.
chasegawa
chasegawa commented Apr 7, 2022
View reviewed changes
grouper-misc/grouper-authentication/plugin-pom.xml
<groupId>${project.groupId}</groupId>
<artifactId>grouper-ui</artifactId>
<version>${grouper.version}</version>
<scope>provided</scope>
Copy link
Author

@chasegawa chasegawa Apr 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (scope=provided anywhere) might need to be removed. Since this is a different classloader, this stuff probably needs to be packaged in with the plugin

sachdeva-vivek and others added 18 commits April 9, 2022 17:14
@sachdeva-vivek
SQL provisioning start with
cf748f5
@sachdeva-vivek
Merge branch 'GROUPER_2_6_BRANCH' of https://github.com/Internet2/gro…
329b601 
…uper into GROUPER_2_6_BRANCH
@sachdeva-vivek
Add Duo provisioning start with
619387b
@sachdeva-vivek
GRP-3987: Bug fix: Delete attribute def names from attribute def screen
0c4acac
@mchyzer
GRP-3990: colons in basic auth passwords with WS LDAP doesnt work
46707f2
@sachdeva-vivek
Fix test
55d89af
@sachdeva-vivek
Merge branch 'GROUPER_2_6_BRANCH' of https://github.com/Internet2/gro…
16a98a2 
…uper into GROUPER_2_6_BRANCH
@mchyzer
provisioner screen doesnt work with no start with
c3e4ca2
@mchyzer
fix quotes on documentation hide/show in provisioning
58cdbe1
@mchyzer
GRP-3999: provisioning: add advanced entity attribute configuration
ad9112a
@mchyzer
GRP-4000: provisioning entity attribute value settings
aa9149d
@mchyzer
GRP-4001: configure provisioning sql foreign keys in the membership2
63d307e 
section
@mchyzer
GRP-4002: provisioning add membership advanced sections and move sql
ae3b8a7 
search query there
@sachdeva-vivek @mchyzer
Add group assign to view for provisioning
2a63f94
@sachdeva-vivek @mchyzer
Use group subject as multikey in group allowed to view/assign cache
c095454
@mchyzer
GRP-4004: provisioning sql membership primary key config move to
cacbf43 
membership2 and drop down
@mchyzer
GRP-4006: current buckets to be refactored from fromId2, toId2 to be
5079a6b 
AttributeValueCache0-3
@mchyzer
GRP-4007: fullSyncGroups wrong option in drop down
55ef92d
scalding and others added 30 commits June 7, 2022 12:17
@scalding
[WIP]
90c77af 
allow configurability
@scalding
[WIP]
40cfc3d 
update osgi
use services
@scalding
add project for test ui
a7aad73
@scalding
add jetty plugin
6527d65
@mchyzer
GRP-4069: remove loginid from entity provisioner drop down
15614bc
@mchyzer
Merge pull request Internet2#178 from UniconLabs/osgi_updates
81b2c61 
OSGI updates
@mchyzer
GRP-4068: provisioning (non membership) attributes not updated with
8b9c91e 
incremental
@scalding
[GRP-4072]
ca43cc2 
move osgi initialization
@scalding
Merge branch 'test_ui' into GRP-4076
047d565
@sachdeva-vivek
Clear config cache in mock servers and fix group compare for updates
e37412e
@sipatel2
GRP-4086: Trace memberships timeline should show states for additiona…
59cf048 
…l groups found in events
@scalding
[GRP-4072]
4302384 
add missing file
update servlet api version
Grouper Start at servlet container initialization
actually add the change to use a temp directory for osgi cache :-D
@sachdeva-vivek
Fix tests
c744f3e
@sachdeva-vivek
Merge branch 'GROUPER_2_6_BRANCH' of https://github.com/Internet2/gro…
c0c108c 
…uper into GROUPER_2_6_BRANCH
@mchyzer
GRP-4103: create a string representation of provisioning objects
6d3b5f3
@sachdeva-vivek
Secondary searches for groups
0a76a65
@sachdeva-vivek
Merge branch 'GROUPER_2_6_BRANCH' of https://github.com/Internet2/gro…
7c144ef 
…uper into GROUPER_2_6_BRANCH
@mchyzer
GRP-4107: allow update to sql provisioning attribute table foreign key
4edd7df 
to main group/entity table
@mchyzer
GRP-4110: match groups on multiple attributes and past values
7114843
@mchyzer
Merge pull request Internet2#158 from UniconLabs/bugfix/IGA-417
dfe6c7f 
[IGA-417]
@mchyzer
GRP-4113: search for groups on multiple attributes and past values
cf089b8
@sipatel2
GRP-4085: resolve subject without cache from provisioning and ui
9b39f87
@sachdeva-vivek
GRP-4099 - Add daemon actions dropdown on daemon logs screen
9c17afb
@sachdeva-vivek
GRP-4099: Add messages to display on screen
2a7448b
@sipatel2
GRP-4085: resolve subject without cache from provisioning and ui (com…
a2944cb 
…mit 2)
@mchyzer
Merge pull request Internet2#180 from UniconLabs/GRP-4076
f96f3be 
Grp 4076
@scalding @mchyzer
[IGA-462]
8c2ccc0 
remove unneeded cross joins
@scalding
Merge branch 'GROUPER_2_6_BRANCH' into feature/IAMSE-1531
f6c475e 
# Conflicts:
#	grouper-misc/webapp/grouper-ui-webapp/pom.xml
#	grouper-misc/webapp/grouper-ui-webapp/src/test/resources/grouper.properties
#	grouper-parent/pom.xml
#	grouper/src/grouper/edu/internet2/middleware/grouper/j2ee/CommonServletContainerInitializer.java
#	grouper/src/grouper/edu/internet2/middleware/grouper/plugins/BundleStarter.java
#	grouper/src/grouper/edu/internet2/middleware/grouper/plugins/FrameworkStarter.java
@scalding
remove log message
3d0e13e
@cer28
Revert unrelated space changes from 0718930
ab1f0f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scalding scalding Awaiting requested review from scalding

Assignees

@chasegawa chasegawa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@chasegawa @scalding @mchyzer @sachdeva-vivek @sipatel2 @cer28 @ydelattre