Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework getting subscriptions list #138

Merged
merged 18 commits into from
Jan 22, 2022
Merged

Rework getting subscriptions list #138

merged 18 commits into from
Jan 22, 2022

Conversation

UncleGoogle
Copy link
Owner

@UncleGoogle UncleGoogle commented Aug 10, 2020

Should fix #165 #167

  • more reliable source of username
  • fix getting username for non-subscribers
  • separate "not-yet-unlocked choice content" users from "never-subscriber" users in terms of fetching active content product machine name
  • some refactors

@lgtm-com
Copy link

lgtm-com bot commented Sep 5, 2020

This pull request introduces 3 alerts when merging 43550df into 96e3214 - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Wrong number of arguments in a call

@lgtm-com
Copy link

lgtm-com bot commented Oct 11, 2021

This pull request introduces 1 alert when merging f0f7316 into 046e1e3 - view on LGTM.com

new alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Oct 12, 2021

This pull request introduces 2 alerts when merging 1220301 into ffe063e - view on LGTM.com

new alerts:

  • 2 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Oct 14, 2021

This pull request introduces 2 alerts when merging 63c2997 into ffe063e - view on LGTM.com

new alerts:

  • 2 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Nov 6, 2021

This pull request introduces 1 alert when merging 68ddfc9 into ffe063e - view on LGTM.com

new alerts:

  • 1 for Unused import

@UncleGoogle UncleGoogle changed the title WIP: Do not import Trove games from outside user subscription period Rework getting subscriptions list Nov 6, 2021
@UncleGoogle UncleGoogle changed the title Rework getting subscriptions list Rework getting subscriptions list and fix getting username Nov 6, 2021
@UncleGoogle UncleGoogle changed the title Rework getting subscriptions list and fix getting username Rework getting subscriptions list and fix getting username for non-subscribers Nov 6, 2021
@lgtm-com
Copy link

lgtm-com bot commented Nov 6, 2021

This pull request introduces 1 alert when merging 6adf13c into ffe063e - view on LGTM.com

new alerts:

  • 1 for Unused import

@UncleGoogle
Copy link
Owner Author

to myself: continue WIP commit from trove_from_last_sub_strategy_draft

@UncleGoogle UncleGoogle changed the title Rework getting subscriptions list and fix getting username for non-subscribers Rework getting subscriptions list Jan 17, 2022
@UncleGoogle UncleGoogle merged commit 1535af1 into master Jan 22, 2022
@UncleGoogle UncleGoogle deleted the trove_from_last_sub branch January 22, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing subscriptions fails with code 4 (Backend responded in unknown way)
1 participant