Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphic Buffers Update #714

Closed
wants to merge 10 commits into from
Closed

Commits on Mar 7, 2021

  1. 'Fix' VAO usage.

    I'm not sure why we're using VAO's when so much seems to be recreated each render, but this way at least the VAO itself wouldn't also be recreated even if the objects aren't.
    bremco committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    3e6ed53 View commit details
    Browse the repository at this point in the history
  2. Actually VertexArrayObjects.

    Still TODO: Once the RenderBatch isn't recreated each time a slightly different render is made, VertexArrayObjects will actually be used, instead of just pretended to be used.
    Also still TODO: any model will render as if the base color is matte dark grey. All the other rendering (like for 'lay-flat by face' or the blue model outline or the tool-arrows and such) and all the rendering _given that the cube is matte grey_ (like 'the error polka dot pattern' and the 'below the buildplate inversion') will still work properly. So everything works _except_ for the color and light-highlights. Why?
    bremco committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    38b4e25 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2021

  1. Configuration menu
    Copy the full SHA
    702d450 View commit details
    Browse the repository at this point in the history
  2. Cache VAO in mesh per shader.

    VAO includes shader uniforms, which where needed. So now, instead of cacheing per mesh alone, cache per mesh _per shader_. Currently the doesn't work 100% yet if different parts of a mesh are rendered with different settings, such as in the simulation view. Also need to check if the X-Ray view was supposed to be opaque or if that's another thing that doesn't work 100% yet (is usable though just not as pretty as remembered).
    bremco committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    c6b6b75 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2021

  1. Handle render-range in shader.

    Instead of re-uploading the mesh each time the range changes, handle the range in the shaders with the new draw-range parameters.
    bremco committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    f73fe2e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    06d7fa5 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. Apply suggestions from code review

    Typing edition.
    
    Co-authored-by: Jaime van Kessel <[email protected]>
    bremco and nallath authored Jul 26, 2021
    Configuration menu
    Copy the full SHA
    c78e13a View commit details
    Browse the repository at this point in the history
  2. Actually fix typing.

    Seems to have fixed the test as well. Not sure if it was ever a valid test if it can't create a VAO there.
    bremco committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    3d0fd5e View commit details
    Browse the repository at this point in the history
  3. More type-wrangling.

    Fixes type laziness, types should work harder!
    bremco committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    8611188 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2021

  1. Apply review sugestion: Fix type.

    Co-authored-by: Aldo Hoeben <[email protected]>
    bremco and fieldOfView authored Jul 27, 2021
    Configuration menu
    Copy the full SHA
    2fa308b View commit details
    Browse the repository at this point in the history