Apply scarf seam and speed gradient in surface mode #2158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CURA-12176 The addSplitWall method is now a template so that it can handle either ExtrusionLine or Polygon objects. It also takes a function as parameter because the way we add extrusion lines is not the same for surface mode and normal mode. In order to simplify this function, I added a PathAdapter class to work with different types of paths with more transparency.
rburema
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CURA-12176
The addSplitWall method is now a template so that it can handle either ExtrusionLine or Polygon objects. It also takes a function as parameter because the way we add extrusion lines is not the same for surface mode and normal mode.
In order to simplify this function, I added a PathAdapter class to work with different types of paths with more transparency.
I am not completely satisfied of this fix. The initial decision I took of handling the scarf seam while adding the extrusion moves now appears very bad to me. This should have been a LayerPlan post-processing function similar to what gradual flow does. I suggest adding a ticket to refactor this, or I fear we will discover other bad interactions between scarf seam, speed gradient and gradual flow, and in the future if we want to add more similar behaviors, it will really be a mess.