CURA-12175 Fix scarf seam and coasting interaction #2155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CURA-12175 This is basically a rewrite of the coasting implementation. The coasting is now fully pre-calculated before processing the paths, because we need to do it partially anyway, then the second part just applies the result of the calculations.
rburema
reviewed
Oct 23, 2024
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: f376224 | Previous: 669da73 | Ratio |
|---|---|---|---|
SimplifyTestFixture/simplify_local |
8.658870874472235 ns/iter |
1.2420916705525211 ns/iter |
6.97 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @nallath @jellespijker @wawanbreton @casperlamboo @saumyaj3 @HellAholic
rburema
reviewed
Oct 24, 2024
|
Performance spike got back to normal as I expected. We had a similar case last week, quite annoying 🤔 |
HellAholic
deleted the
CURA-12175_Coasting-Scarf-seam-creates-two-seams
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things were incorrect in the current pre-calculation of the coasting settings. I also merged the pre-calculation with the post-calculation so that we don't calculate anything twice, which should make the whole thing faster. Now the second part just applied what the first part has calculated.
CURA-12175