CURA-12023 Fix ghost prime tower #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check was removed while working on the smaller prime tower, to rely only on the max_print_height_second_to_last_extruder variable. However, this one can be miscalculated in some conditions because it is done very early. We then use storage.getExtrudersUsed() again to check the actual extruders use. This may leave some edge cases where a ghost prime tower could appear, but they should now be very limited. CURA-12026
rburema
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore the check to used extruders to create prime tower: this check was removed while working on the smaller prime tower, to rely only on the
max_print_height_second_to_last_extrudervariable. However, this one can be miscalculated in some conditions because it is done very early. We then usestorage.getExtrudersUsed()again to check the actual extruders use.This may leave some edge cases where a ghost prime tower could appear, but they should now be very limited.
CURA-12026