Mac fixes prime tower #2112
Merged
Mac fixes prime tower #2112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we can't have the performance improvements provided by emplace_back and its construct-in-place mechanism without adding a lot of code (constructors for the struct), just use push_back to emphasize the fact that we are constructing the objects then putting them into the list. This is fine though, we don't actually need performance in this case.
rburema
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix build issue on MAC when using the
emplace_backmethodThe XCode compiler seems to be stricter about structs default constructors, so we can't use
emplace_backand the construct-in-place mechanism without manually declaring the constructors, which would be overkill in this case. We don't really need the provided performance improvement because those operations are not done thousands of times. Just usepush_backwith the explicit struct default constructor.