CURA-6410 buggy fan speed interpolation #2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…buggy_fan_speed_interpolation
Previously we were basing the writing or non-writing of the fan speed command based on the raw value comparison. This could result in some commands not being written if the new value was too much similar to the previous one. Now we check the actual output value and base the writing on this. CURA-6410
rburema
requested changes
Jul 4, 2024
There was a problem hiding this comment.
I've got 2 remarks. -- Most importantly, ideally, I'd really like the string-manipulation to be gone, but currently, I don't even understand how that would work correctly and keep the right numbers 😅
The (other) remark about DRY is just a preference and I can live with it if not easy to fix.
Lastly, I do think the 1st commit cleans things up considerably though -- I can at least understand what's going on now there 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checking for the fan miminum layer time was based on the wrong variable.
I also reworked the fan speed command to better handle interpolated values.
CURA-6410
Fixes Ultimaker/Cura#5409