Cura 11227 zseam support #2067
Merged
Cura 11227 zseam support #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of the order optimizer has been updated to account for the z-seam type for support. This includes adjustment of the start point calculation and Both 'InsetOrderOptimizer' and 'PathOrderOptimizer' classes have been modified to accommodate these changes. CURA-11227
This update tweaks handling of the z-seam by allowing it to shift away from the model based on specific settings. It also introduces better path optimization, by calculating the shortest distance from a point to a line segment, optimizing how the best position is retrieved if such support exists and dealing with edge cases where no optimal starting path is found. CURA-11227
Refactored the logic of the PathOrderOptimizer function to ensure 'number_of_paths_analysed' is increased and reset only in the suitable scenarios. Also, corrected the case of a warning message related to the 'z seam distance'. CURA-11227
casperlamboo
requested changes
Apr 29, 2024
The code changes revolve around the functionality of the InsetOrderOptimizer and related path optimizers. These changes allow for better handling of support meshes by allowing the optimizer to consider if a layer part is supported or not. Furthermore, the type of paths used in path optimization was switched from 'ClipperLib::Paths' to 'Polygons' providing better performance and cleaner code. Also, the conditions for EZSeamType::SUPPORT in the seam configuration were removed. CURA-11227
Instead of specific case of support away from model, now it is given from Insetoptimiser as disallowed area. this can also be used for other features in future. CURA-11227
The specific "support away from model" case has been refactored to a more generic "disallowed areas" in the Insetoptimizer. This adjustment enhances flexibility and allows for potential future utilization in other features. Related to CURA-11227.
casperlamboo
approved these changes
May 2, 2024
Renamed the variable 'disallowed_area' to 'disallowed_areas_for_seams' in different files for more accurate representation. CURA-11227
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support z-seam type to inset order optimization
The implementation of the order optimizer has been updated to account for the z-seam type for support. This includes adjustment of the start point calculation and Both 'InsetOrderOptimizer' and 'PathOrderOptimizer' classes have been modified to accommodate these changes.
CURA-11227