[CURA-11444] Use 'wagyu' to prevent slicing crashes #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: this still a temporary condition to apply wagyu CURA-11444
It's not the most elegant code, but the alternative would be renaming either all of the x,y to X,Y in wagyu, or all of the X,Y to x,y for clipperlib-intpoints. proposed part of CURA-11444
rburema
changed the title
casperlamboo
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: The same failing tests are also happening on main.
Input polygons into Arachne weren't guaranteed to be 'not nearly self intersecting', but it needed that requirement. Use mapbox/wagyu to make the polygons going in conform.
Has a reinterpret-cast/move instead of copying the polygons, which is needed, because otherwise either the mapbox point type (which assumes small x,y) or 'our' ClipperLib:IntPoint type (which uses capital X,Y) would have to change all throughout either the wagyu library or our codebase respectively.