Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tree support related crash that occurs if there are no overhangs #2028

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

ThomasRahm
Copy link
Contributor

Description

Fixes tree support related crash that occurs if there are no overhangs. It also abort tree support generation early if there are no overhangs to support.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

  • Operating System:
    Windows 10

Checklist:

  • My code follows the style guidelines of this project as described in UltiMaker Meta
  • I have read the Contribution guide
  • I have commented my code, particularly in hard-to-understand areas
  • I have uploaded any files required to test this change

… Also abort tree support generation early if there are no overhangs to support.
@github-actions github-actions bot added the PR: Community Contribution 👑 Community Contribution PR's label Feb 2, 2024
@saumyaj3 saumyaj3 merged commit b343d88 into Ultimaker:main Feb 15, 2024
11 of 12 checks passed
@saumyaj3
Copy link
Contributor

Hey @ThomasRahm Thankyou for your valuable contribution. You make Cura community very happy 👯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants