[CURA-11157] Remove 'support_interface_skip_height' setting #2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was used for run-time efficiency, but it wasn't really ever set beyond one layer-height, which made it rather useless. engine part of CURA-11157
|
Why not completely remove all references to skip layer height instead of defaulting it to 1 (see #2010). I think by leaving the references to "old unused features" we unnecessarily increase the complexity of the engine. |
|
@casperlamboo Good point -- I didn't want to alter too much in this ticket, but perhaps it can be done simply. Let me have a look. |
This was redundant now that the setting is removed, and it's always set to 1. part of CURA-11157
|
Done! |
casperlamboo
approved these changes
Jan 10, 2024
casperlamboo
deleted the
CURA-11157_remove_support_interface_skip_height
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was used for run-time efficiency, but it wasn't really ever set beyond one layer-height, which made it rather useless.
For the frontend PR see Ultimaker/Cura#17961