Fix issue where part of raft was missing #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nallath
approved these changes
Nov 27, 2023
casperlamboo
added a commit
that referenced
this pull request
Jan 11, 2024
We already implemented it for the raft top, see #1989 CURA-11395
wawanbreton
pushed a commit
to wawanbreton/CuraEngine
that referenced
this pull request
Jan 18, 2024
We already implemented it for the raft top, see Ultimaker#1989 CURA-11395
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to the special shape of the polygon it is possible to “stitch” the polylines into a closed polygon loop. See svg’s below, first image is the input to the stitching algorithm and the second is the output of the stitching algorithm. The blue color denotes open polylines, and the red color denotes closed polygons.
As you can see in the output put polygon a closed loop was indeed found. However, in the code we always assumed that the output of “ZigZagged” infill never contained any closed polygon loops https://github.com/Ultimaker/CuraEngine/blob/main/src/FffGcodeWriter.cpp#L576, and thus these were never added.
CURA-11355
Type of change
How Has This Been Tested?
yassss
Test Configuration:
Checklist: