CURA-11378 stress benchmarks #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reads in a number of known problematic polygons and settings and counts how many crashes occur in those shapes Contributes to CURA-11378
Contributes to CURA-11378
Showing the failed test cases in the tooltip Contributes to CURA-11378
Contributes to CURA-11378
7 tasks
|
|
||
| std::vector<Resource> getResources() | ||
| { | ||
| auto resource_path = std::filesystem::path(std::source_location::current().file_name()).parent_path().append("resources"); |
There was a problem hiding this comment.
std::source_location is not available on mac 😔
rburema
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
LGTM.
I like it when both of you are on a ticket, makes reviewing easy; when walking through the commits, each time when one of you introduces something I don't like the other removes it like 2 commits later :-p
I'll try to merge main into it, if that passes (enough), I'll merge it back to main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://ultimaker.github.io/CuraEngineBenchmarks/dev/stress_bench/
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: