[CURA-11359] sanitize code #1986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+144
to
+152
| - name: Upload the detailed tests report | ||
| uses: actions/upload-artifact@v3 | ||
| if: ${{ always() }} | ||
| with: | ||
| name: LastTest.log | ||
| path: | | ||
| build/Release/Testing/Temporary/LastTest.log | ||
| retention-days: 5 | ||
|
|
There was a problem hiding this comment.
should this be part of this PR? seems seperated to me
can it be removed?
Suggested change
| - name: Upload the detailed tests report | |
| uses: actions/upload-artifact@v3 | |
| if: ${{ always() }} | |
| with: | |
| name: LastTest.log | |
| path: | | |
| build/Release/Testing/Temporary/LastTest.log | |
| retention-days: 5 |
There was a problem hiding this comment.
Good catch.. I thought this could be part of it, otherwise it would be lost. Should I make a mini-PR for it ?
|
Also, there are some merge conflicts |
Use at() instead or brackets Co-authored-by: Casper Lamboo <[email protected]>
Remove useless code Co-authored-by: Casper Lamboo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to remove all the compilation warnings issued when using the
enable_extensive_warningsoption is set. On the currant master branch, there are 16000+ warnings which makes it completely impossible to use them relevantly.Most notable changes made:
_as suffix to diferentiate them from local variablesProximityPointLink,ClientSocket).spdlog/fmtversions to suppress some warnings coming from them. This comes wih the same update for synsepalum-dulcificum and also for gradual flow pluginSome parts of the code have become less readable, especially because of the numbers conversions. This emphasizes a global code issue that various types are used and mixed together, which should not happen. This should be fixed along the way.